Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 19, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Follow PR #2790

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Nov 19, 2021

/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.98%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 76.92% 80.00% +3.08%

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by ono-max.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 4ddfd2a into master Nov 19, 2021
@pipecd-bot pipecd-bot deleted the add-deploymentchain-sql-table branch November 19, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants