Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
This PR makes all EnvID(s) optional since we're going to migrate Environment to Labels.
I looked up places where use EnvId and confirmed all seem to be able to work well without EnvId.

Which issue(s) this PR fixes:

Close #2805

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Make all environment fields in the form in optional

https://github.com/pipe-cd/pipe/blob/8c927e24eefda08d3584216dbf173c6f4cc7d52d/pkg/app/web/src/components/application-form/index.tsx#L133-L136

This was created by todo plugin since "TODO:" was found in 8c927e2 when #2812 was merged. cc: @nakabonne.

@khanhtc1202
Copy link
Member


/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.98%. This pull request decreases coverage by -0.18%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetDeployment -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/app/piped/trigger/deployment.go reportMostRecentlyTriggeredDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommandDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommandDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnOutOfSyncDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnOutOfSyncDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommitDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommitDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listOutOfSyncCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommitCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggered -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggerFailed -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/config/deployment.go PostSync.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChain.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChainNode.Validate -- 75.00% +75.00%
pkg/config/deployment.go DeploymentChainTriggerCondition.Validate -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.updateRepoToLatest 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 46.15% 56.25% +10.10%
pkg/config/piped.go SecretManagement.UnmarshalJSON 62.50% 56.25% -6.25%
pkg/app/piped/planpreview/builder.go builder.findTriggerApps 0.00% 0.00% +0.00%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.buildSlackMessage 0.00% 0.00% +0.00%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/planner/kubernetes/kubernetes.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.Run 0.00% 0.00% +0.00%
pkg/config/piped.go PipedSpec.Validate 58.33% 57.14% -1.19%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 76.92% 80.00% +3.08%
pkg/config/sealed_secret.go SealedSecretSpec.Validate 85.71% 71.43% -14.29%
pkg/app/piped/sourcedecrypter/decrypter.go DecryptSealedSecrets 77.27% -- -77.27%
pkg/app/piped/trigger/deployment.go Trigger.reportMostRecentlyTriggeredDeployment 0.00% -- +-0.00%
pkg/app/piped/trigger/deployment.go Trigger.getNotification 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go NewDeterminer 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.ShouldTrigger 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.shouldTriggerOnCommit 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go loadDeploymentConfiguration 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommands 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommits 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.syncApplication 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.listApplications 0.00% -- +-0.00%
pkg/config/piped.go PipedSpec.GetSecretManagement 0.00% -- +-0.00%

@ono-max
Copy link
Member

ono-max commented Nov 19, 2021

There you go.

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by ono-max.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement environmentstore.GetByName

5 participants