Fix a bug that unspecified users can approve the WAIT_APPROVAL stage

[ono-max]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2550

Does this PR introduce a user-facing change?:

Fix a bug that unspecified users can approve the WAIT_APPROVAL stage

[pipecd-bot]

Code coverage for golang is 31.88%. This pull request does not change code coverage.

[nghialv]

I want to ask that why it worked before and do we need to update for other application kinds too?

[ono-max]

Because MakeInitialStageMetadata function is not called when buildProgressivePipeline function is called.

First, I would like to confirm that approvers are retrieved from the metadata and approvers are stored in MakeInitialStageMetadata.

In my case, buildProgressivePipeline function is called as follows:
https://github.com/pipe-cd/pipe/blob/master/pkg/app/piped/planner/kubernetes/kubernetes.go#L205

I noticed that MakeInitialStageMetadata function is not called then and work it.

[ono-max]

@nghialv

do we need to update for other application kinds too?

If you are convinced with this change and the reason, I think we need to update them.

[nghialv]

Ok. I think that was the problem so let's update other kinds too.

[ono-max]

@nghialv

Updated 👍

[pipecd-bot]

Code coverage for golang is 31.88%. This pull request does not change code coverage.

[nghialv]

Nice catch!
/approve

[pipecd-bot]

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.