Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 15, 2021

What this PR does / why we need it:

https://github.com/pipe-cd/pipe/releases/tag/v0.10.0

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The Sealed Secret feature was deleted completely. Please use Secret Management instead.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.97%. This pull request decreases coverage by -0.07%.

File Function Base Head Diff
pkg/config/piped.go PipedSpec.Validate 58.33% 57.14% -1.19%
pkg/config/piped.go SecretManagement.UnmarshalJSON 62.50% 56.25% -6.25%
pkg/config/sealed_secret.go SealedSecretSpec.Validate 85.71% 71.43% -14.29%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 46.15% 53.85% +7.69%
pkg/app/piped/sourcedecrypter/decrypter.go DecryptSealedSecrets 77.27% -- -77.27%
pkg/config/piped.go PipedSpec.GetSecretManagement 0.00% -- +-0.00%

@khanhtc1202
Copy link
Member

/lgtm

@nakabonne
Copy link
Member

See you never!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8268eda into master Nov 15, 2021
@pipecd-bot pipecd-bot deleted the sealed-secret branch November 15, 2021 06:44
pipecd-bot pushed a commit that referenced this pull request Dec 1, 2021
…o be loaded (#2872)


**What this PR does / why we need it**:

That field and all its related stuff have been deleted by #2784 but let me keep only this field at this time to avoid `unknown` field error while loading the config file in our dev environment.

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants