-
Notifications
You must be signed in to change notification settings - Fork 307
Send notification to users via Slack when it fails to trigger deployment #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a7bc70d
Send notification to users via Slack when the application misses .pip…
54bac13
Remove the unused field
06ea6c9
Remove the unused argument
d7b9cb0
Format codes
ceb0c36
Change the event name from "NotificationEventType_EVENT_PIPED_FAILED"…
a5a73ca
Remove defer block
70bdb71
Modify fields in Slack to make it easier to read
811f5bc
Format codes
f179e32
Define a couple of fields in "NotificationEventDeploymentTriggerFaile…
777c9f7
Update pkg/app/piped/notifier/slack.go
4d72d04
Update pkg/model/notificationevent.proto
3fe1d8a
Update name of fields
5e1668b
Remove the unnecessary function
ff81c6f
Use "git.MakeCommitURL" to make a commit link
a7b9ab3
Define variable "commitURL" instead of using "link"
cc626c2
Report failures when it fails to trigger deployment
6c9c67a
Update pkg/app/piped/trigger/deployment.go
3956a08
Navigate title link to Application detail Page
6c1c9bc
Fix links
1829c2d
Fix logs
944908a
Update pkg/app/piped/notifier/slack.go
5028483
Hide Commit field if "commitURL" is empty
6d6df14
Format unfmt-ed files
0f8efd1
Update pkg/app/piped/notifier/slack.go
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.