Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Kapture.2021-08-20.at.18.59.03.mp4

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Move application count badges to Insights page

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

Nice. You made my day!
/approve

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

Oops, the web-test failed.

@khanhtc1202
Copy link
Member Author

Oops, the web-test failed.

Yep, it's my miss, just updated the failed test 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

/approve

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.56%. This pull request increases coverage by 0.05%.

File Base Head Diff
src/components/insight-page/application-counts/index.tsx -- 94.12% +94.12%
src/components/insight-page/application-counts/application-count/index.tsx -- 88.24% +88.24%
src/components/applications-page/index.tsx 48.28% 49.06% +0.78%
src/components/applications-page/application-counts/index.tsx 94.74% -- -94.74%
src/components/applications-page/application-counts/application-count/index.tsx 88.24% -- -88.24%

@pipecd-bot pipecd-bot merged commit bba9133 into master Aug 20, 2021
@pipecd-bot pipecd-bot deleted the update-insight-ui branch August 20, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants