Skip to content

Update manifests to allow specifying cloudrun credentials #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Aug 20, 2021
Merged

Update manifests to allow specifying cloudrun credentials #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/piped/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ data:
{{- if .Values.secret.secretManagementKeyPair.privateKey.data }}
{{ .Values.secret.secretManagementKeyPair.privateKey.fileName }}: {{ .Values.secret.secretManagementKeyPair.privateKey.data | b64enc | quote }}
{{- end }}
{{- if .Values.secret.cloudRunCredentials.data }}
{{ .Values.secret.cloudRunCredentials.fileName }}: {{ .Values.secret.cloudRunCredentials.data | b64enc | quote }}
{{- end }}
{{- if .Values.secret.awsCredentials.data }}
{{ .Values.secret.awsCredentials.fileName }}: {{ .Values.secret.awsCredentials.data | b64enc | quote }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions manifests/piped/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ config:
# branch: master
# syncInterval: 1m

# TODO: Allow adding arbitrary secret files instead of fixing them as currently.
Copy link
Member

@khanhtc1202 khanhtc1202 Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

secret:
# Specifies whether a Secret for storing sensitive data should be created.
create: true
Expand Down Expand Up @@ -80,6 +81,9 @@ secret:
privateKey:
fileName: secret-management-private-key
data: ""
cloudRunCredentials:
fileName: cloudrun-credentials
data: ""
awsCredentials:
fileName: aws-credentials
data: ""
Expand Down