Fix wrong drift result that caused in v0.10.3 #2192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
commented
Jul 7, 2021
| oldManifests, | ||
| newManifests, | ||
| diff.WithEquateEmpty(), | ||
| diff.WithIgnoreAddingMapKeys(), |
Member
Author
There was a problem hiding this comment.
We don't need this option because plan-preview is comparing between 2 commits, not using the live state.
nghialv
commented
Jul 7, 2021
| result, err := provider.DiffList(liveManifests, headManifests, | ||
| result, err := provider.DiffList( | ||
| headManifests, | ||
| liveManifests, |
Member
Author
There was a problem hiding this comment.
The bug was caused by this order change in the last refactoring.
Member
|
Again, the build failed due to npm |
Member
|
/trigger build |
Collaborator
|
@nakabonne: Your requested build has been scheduled in response to this comment. |
Collaborator
|
Code coverage for golang is
|
nakabonne
reviewed
Jul 7, 2021
| b.WriteString(fmt.Sprintf("Diff between the running resources and the definitions in Git at commit %q:\n", commit)) | ||
| b.WriteString("--- Git\n+++ Cluster\n\n") | ||
| b.WriteString(fmt.Sprintf("Diff between the defined state in Git at commit %s and actual state in cluster:\n\n", commit)) | ||
| b.WriteString("--- Expected\n+++ Actual\n\n") |
Member
|
Nice |
Member
|
Nice catch |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: