-
Notifications
You must be signed in to change notification settings - Fork 208
Add relabel config to plot durations for each gRPC method #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/lgtm |
|
Could you add some metrics samples here? (e.g. envoy_cluster_grpc_*_upstream_rq_time_bucket) |
|
@nghialv You're right. Some examples here: |
manifests/pipecd/values.yaml
Outdated
| - source_labels: [__name__] | ||
| target_label: __name__ | ||
| regex: envoy_cluster_grpc_(.+)_(.+)_(.+)_(.+)_upstream_rq_time_bucket$ | ||
| replacement: pipecd_requests_duration_bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add envoy to the name? for example, pipecd_envoy_requests_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure, or pipecd_gateway_requests_ seems to be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this is a relabel_config for the pipecd-gateway job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. That is better. 👍
|
Thank you for looking over. Applied them! |
|
Nice. |
|
/approve |
What this PR does / why we need it:
For durations, stats reported by Envoy is enough to see.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: