Skip to content

Add inmemory cache metrics #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Jul 2, 2021
Merged

Add inmemory cache metrics #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/cache/memorycache/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ go_library(
visibility = ["//visibility:public"],
deps = [
"//pkg/cache:go_default_library",
"//pkg/cache/cachemetrics:go_default_library",
"@com_github_hashicorp_golang_lru//:go_default_library",
],
)
Expand Down
9 changes: 9 additions & 0 deletions pkg/cache/memorycache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"sync"

"github.com/pipe-cd/pipe/pkg/cache"
"github.com/pipe-cd/pipe/pkg/cache/cachemetrics"
)

type Cache struct {
Expand All @@ -31,8 +32,16 @@ func NewCache() *Cache {
func (c *Cache) Get(key interface{}) (interface{}, error) {
item, ok := c.values.Load(key)
if !ok {
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusMiss,
)
return nil, cache.ErrNotFound
}
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusHit,
)
return item, nil
}

Expand Down
9 changes: 9 additions & 0 deletions pkg/cache/memorycache/lru_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
lru "github.com/hashicorp/golang-lru"

"github.com/pipe-cd/pipe/pkg/cache"
"github.com/pipe-cd/pipe/pkg/cache/cachemetrics"
)

type LRUCache struct {
Expand All @@ -37,8 +38,16 @@ func NewLRUCache(size int) (*LRUCache, error) {
func (c *LRUCache) Get(key interface{}) (interface{}, error) {
item, ok := c.cache.Get(key)
if !ok {
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusMiss,
)
return nil, cache.ErrNotFound
}
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusHit,
)
return item, nil
}

Expand Down
9 changes: 9 additions & 0 deletions pkg/cache/memorycache/ttl_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"time"

"github.com/pipe-cd/pipe/pkg/cache"
"github.com/pipe-cd/pipe/pkg/cache/cachemetrics"
)

type entry struct {
Expand Down Expand Up @@ -70,8 +71,16 @@ func (c *TTLCache) evictExpired(t time.Time) {
func (c *TTLCache) Get(key interface{}) (interface{}, error) {
item, ok := c.entries.Load(key)
if !ok {
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusMiss,
)
return nil, cache.ErrNotFound
}
cachemetrics.IncGetOperationCounter(
cachemetrics.LabelSourceInmemory,
cachemetrics.LabelStatusHit,
)
return item.(*entry).value, nil
}

Expand Down