Enable to track request response size statistics #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
Code coverage for golang is |
pipecd-bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
) This reverts commit cf502d5. **What this PR does / why we need it**: Seems like the config field `track_cluster_stats` is supported only for [V3](https://www.envoyproxy.io/docs/envoy/latest/api-v3/api) API [introduced from v1.13](https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.13.0). On the other hand our current version of Envoy is 1.10 which supports only v2 API. Currently, the latest version of `pipecd-gateway` is unavailable due to unable to parse the config so this PR reverts for now. But either way, we'd better bump Envoy to after v1.13 (current latest is v1.19) as soon as possible because [V2 API is no longer supported](https://www.envoyproxy.io/docs/envoy/latest/api/api_supported_versions). **Which issue(s) this PR fixes**: Fixes # **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
nakabonne
added a commit
that referenced
this pull request
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To track request/response body size, this PR adds a new config field.
See more: https://www.envoyproxy.io/docs/envoy/latest/configuration/upstream/cluster_manager/cluster_stats#request-response-size-statistics
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: