Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Screen Shot 2021-06-28 at 10 42 06

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE


<div class="mx-auto">
<a class="release-panel" target="_blank" href="https://github.com/pipe-cd/pipe/releases">
PipeCD <span class="bolder">0.10.2</span> is now available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.10.2
It would be nice if this could be fetched automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would. Updating manually is quite tedious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, the current commit just because I don't actually know how to get that value. But as for an idea, maybe we could automatically generate it as we do with the release note? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cakecatz Is there any good way to add a script to load the latest version from this file when the page is loaded?
https://github.com/pipe-cd/pipe/blob/master/release/RELEASE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 this command (with jq) will fetch the latest tag name

curl --silent "https://api.github.com/repos/pipe-cd/pipe/releases/latest" | jq ".tag_name"

Copy link
Member Author

@khanhtc1202 khanhtc1202 Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this 👀 8859312
Just adopted @nghialv 's idea but instead of parsing the RELEASE file, I used --abbrev=0 --tags which could provide the same result without parsing logic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good except for doing a patch release. In that case, the tag and the version number specified in the RELEASE file will not be the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, then I need at least curl and cut command to process this data like below 👀

╰─ curl --silent https://raw.githubusercontent.com/pipe-cd/pipe/master/release/RELEASE | cut -c9-  
 v0.10.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use "cut" for the local file. The whole repo was already cloned.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed on 3f7e6e5 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

<a class="btn btn-lg btn-primary mr-3 mb-4" href="{{< relref "/docs" >}}">
Learn More <i class="fas fa-arrow-alt-circle-right ml-2"></i>
<a class="btn btn-lg btn-primary mr-3 mb-4" href="{{< relref "/docs/quickstart/" >}}">
Quick Start <span class="ml-2">🚀</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't really like this rocket icon much. Its color does not match our theme.
No strong opinion, but one vote from me to remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 😂 then what should I use there, should we keep the arrow as the existing version of the cover 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to use the previous arrow icon 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.45%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

Nice
/lgtm

@nghialv
Copy link
Member

nghialv commented Jun 28, 2021

Nice. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2af3bd8 into master Jun 28, 2021
@pipecd-bot pipecd-bot deleted the update-docs-panel branch June 28, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants