Allow several types to be used by Event watcher #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/lgtm |
Collaborator
|
Code coverage for golang is
|
Member
Author
|
Sorry, just replaced |
Collaborator
|
Code coverage for golang is
|
khanhtc1202
reviewed
Jan 22, 2021
| case bool: | ||
| out = strconv.FormatBool(v) | ||
| default: | ||
| return "", fmt.Errorf("%T", v) |
Member
There was a problem hiding this comment.
nits
- return "", fmt.Errorf("%T", v)
+ err = fmt.Errorf("unable to convert: %T", v)
khanhtc1202
reviewed
Jan 22, 2021
Comment on lines
48
to
59
| { | ||
| name: "uint64", | ||
| value: uint64(1), | ||
| want: "1", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "uint64", | ||
| value: uint64(1), | ||
| want: "1", | ||
| wantErr: false, | ||
| }, |
khanhtc1202
reviewed
Jan 22, 2021
Collaborator
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Validate value in YAML before actual readingThis was created by todo plugin since "TODO:" was found in 2863def when #1467 was merged. cc: @nakabonne. |
Member
Author
|
@khanhtc1202 Thank you! PTAL again! |
Member
|
thank you 😊 |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Jan 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Depending on the value, the type of value can be a variety of one.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: