Skip to content

Using aws.StringValue and destructuring map with key value pair #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 2 commits into from
Jan 22, 2021
Merged

Using aws.StringValue and destructuring map with key value pair #1464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9934c54
Using aws.StringValue and destructuring map with key value pair
khanhtc1202 Jan 22, 2021
fdcf8bf
Using float64Value
khanhtc1202 Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/app/piped/cloudprovider/lambda/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func (c *client) PublishFunction(ctx context.Context, fm FunctionManifest) (vers
}
return
}
version = *cfg.Version
version = aws.StringValue(cfg.Version)
return
}

Expand Down Expand Up @@ -254,24 +254,24 @@ func (c *client) GetTrafficConfig(ctx context.Context, fm FunctionManifest) (rou
// In case RoutingConfig is nil, 100 percent of current traffic is handled by FunctionVersion version.
if cfg.RoutingConfig == nil {
routingTrafficCfg["primary"] = VersionTraffic{
Version: *cfg.FunctionVersion,
Version: aws.StringValue(cfg.FunctionVersion),
Percent: 100,
}
return
}
// In case RoutingConfig is provided, FunctionVersion value represents the primary version while
// RoutingConfig.AdditionalVersionWeights key represents the secondary version.
var newerVersionTraffic float64
for version := range cfg.RoutingConfig.AdditionalVersionWeights {
newerVersionTraffic = percentageToPercent(*cfg.RoutingConfig.AdditionalVersionWeights[version])
var secondaryVersionTraffic float64
for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights {
secondaryVersionTraffic = percentageToPercent(aws.Float64Value(weight))
routingTrafficCfg["secondary"] = VersionTraffic{
Version: version,
Percent: newerVersionTraffic,
Percent: secondaryVersionTraffic,
}
}
routingTrafficCfg["primary"] = VersionTraffic{
Version: *cfg.FunctionVersion,
Percent: 100 - newerVersionTraffic,
Version: aws.StringValue(cfg.FunctionVersion),
Percent: 100 - secondaryVersionTraffic,
}

return
Expand Down