Skip to content

Redesign lambda application config #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 2 commits into from
Jan 15, 2021
Merged

Redesign lambda application config #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45cf1c7
Redesign lambda application config
khanhtc1202 Jan 15, 2021
619fe29
Remove Runtime and Handler
khanhtc1202 Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/lambda/analysis/.pipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
apiVersion: pipecd.dev/v1beta1
kind: LambdaApp
spec:
input:
# Lambda code sourced from the same Git repository.
path: lambdas/helloworld
pipeline:
stages:
# Deploy workloads of the new version.
Expand Down
7 changes: 7 additions & 0 deletions examples/lambda/analysis/function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: pipecd.dev/v1beta1
kind: LambdaFunction
spec:
name: SimpleFunction
image: ecr.ap-northeast-1.amazonaws.com/lambda-test:v0.0.1
tags:
app: simple
3 changes: 0 additions & 3 deletions examples/lambda/canary/.pipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
apiVersion: pipecd.dev/v1beta1
kind: LambdaApp
spec:
input:
# Lambda code sourced from the same Git repository.
path: lambdas/helloworld
pipeline:
stages:
# Deploy workloads of the new version.
Expand Down
7 changes: 7 additions & 0 deletions examples/lambda/canary/function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: pipecd.dev/v1beta1
kind: LambdaFunction
spec:
name: SimpleFunction
image: ecr.ap-northeast-1.amazonaws.com/lambda-test:v0.0.1
tags:
app: simple
10 changes: 0 additions & 10 deletions examples/lambda/remote-git/.pipe.yaml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions examples/lambda/simple/function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@ kind: LambdaFunction
spec:
name: SimpleFunction
image: ecr.ap-northeast-1.amazonaws.com/lambda-test:v0.0.1
runtime: nodejs12.x
handler: app.lambdaHandler
tags:
app: simple
8 changes: 0 additions & 8 deletions pkg/app/piped/cloudprovider/lambda/function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ type FunctionManifestSpec struct {
Name string `json:"name"`
ImageURI string `json:"image"`
Tags map[string]string `json:"tags,omitempty"`
Runtime string `json:"runtime"`
Handler string `json:"handler"`
}

func (fmp FunctionManifestSpec) validate() error {
Expand All @@ -62,12 +60,6 @@ func (fmp FunctionManifestSpec) validate() error {
if len(fmp.ImageURI) == 0 {
return fmt.Errorf("image uri is missing")
}
if len(fmp.Runtime) == 0 {
return fmt.Errorf("runtime is missing")
}
if len(fmp.Handler) == 0 {
return fmt.Errorf("handler is missing")
}
return nil
}

Expand Down
4 changes: 0 additions & 4 deletions pkg/app/piped/cloudprovider/lambda/function_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ func TestparseFunctionManifest(t *testing.T) {
"kind": "LambdaFunction",
"spec": {
"name": "SimpleFunction",
"runtime": "nodejs12.x",
"handler": "SampleFunction",
"image": "ecr.region.amazonaws.com/lambda-simple-function:v0.0.1"
}
}`,
Expand All @@ -45,8 +43,6 @@ func TestparseFunctionManifest(t *testing.T) {
Spec: FunctionManifestSpec{
Name: "SimpleFunction",
ImageURI: "ecr.region.amazonaws.com/lambda-simple-function:v0.0.1",
Runtime: "nodejs12.x",
Handler: "SampleFunction",
},
},
wantErr: false,
Expand Down