Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jan 13, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1369

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv changed the title [WIP] Update controller to detect and mark deploying status for applications Update controller to detect and mark deploying status for applications Jan 13, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.91%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/piped/controller/controller.go reportApplicationDeployingStatus -- 0.00% +0.00%
pkg/app/piped/controller/planner.go planner.DoneDeploymentStatus -- 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.syncPlanners 0.00% 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.syncSchedulers 0.00% 0.00% +0.00%
pkg/app/piped/controller/planner.go planner.Run 0.00% 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.reportApplicationDeployingStatus 0.00% -- +-0.00%

@nakabonne
Copy link
Member

/lgtm

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 3ca2e1a into master Jan 14, 2021
@pipecd-bot pipecd-bot deleted the deploying branch January 14, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign the way to mark an application as deploying

5 participants