Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 13, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Refs #1369

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.09%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.96%. This pull request increases coverage by 0.01%.

File Base Head Diff
src/components/sync-status-icon.tsx 75.00% 78.57% +3.57%

@nghialv
Copy link
Member

nghialv commented Jan 13, 2021

@cakecatz Nice. Thank you. I just want to confirm its behavior.

app.deploying app.syncState.status Shown Icon
true ApplicationSyncStatus.SYNCED DEPLOYING
true ApplicationSyncStatus.OUT_OF_SYNC DEPLOYING
true ApplicationSyncStatus.UNKNOWN DEPLOYING
true ApplicationSyncStatus.DEPLOYING DEPLOYING
false ApplicationSyncStatus.SYNCED SYNCED
false ApplicationSyncStatus.OUT_OF_SYNC OUT_OF_SYNC
false ApplicationSyncStatus.UNKNOWN N/A
false ApplicationSyncStatus.DEPLOYING DEPLOYING

Is this correct?

@cakecatz
Copy link
Contributor Author

@nghialv That is almost correct.

ApplicationSyncStatus.UNKNOWN also displays the icon.

image
unknown, synced, deploying, out of sync

@nghialv
Copy link
Member

nghialv commented Jan 13, 2021

So this is what we are expecting, right?

app.deploying app.syncState.status Shown Icon Shown Title
true ApplicationSyncStatus.SYNCED deploying Deploying
true ApplicationSyncStatus.OUT_OF_SYNC deploying Deploying
true ApplicationSyncStatus.UNKNOWN deploying Deploying
true ApplicationSyncStatus.DEPLOYING deploying Deploying
false ApplicationSyncStatus.SYNCED synced Synced
false ApplicationSyncStatus.OUT_OF_SYNC out_of_sync Out of Sync
false ApplicationSyncStatus.UNKNOWN unknown Unknown
false ApplicationSyncStatus.DEPLOYING deploying Deploying

@nghialv
Copy link
Member

nghialv commented Jan 13, 2021

Looks good. Thank you.
/lgtm

@khanhtc1202
Copy link
Member

🚀 🚀 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 76def18 into master Jan 13, 2021
@pipecd-bot pipecd-bot deleted the deploying branch January 13, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants