Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jan 13, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1415

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.07%. This pull request increases coverage by 0.08%.

File Function Base Head Diff
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.Validate 0.00% 66.67% +66.67%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.Validate 0.00% 66.67% +66.67%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.Validate 100.00% 66.67% -33.33%
pkg/config/config.go Config.init 80.00% 96.00% +16.00%

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jan 13, 2021

https://github.com/pipe-cd/pipe/blob/c137f9e2ef3e5bf3b9393cabad7dac2cace36889/pkg/config/config.go#L196-L206

I think we should update the validation calling logic too 👀
At L200, in case c.spec could not be cast to validator type, we ignore it and return no error. In case LambdaDeployementSpec, CloudrunDeploymentSpec, TerraformDeploymentSpec does not satisfy validator interface, error should be raised.

@nghialv
Copy link
Member Author

nghialv commented Jan 13, 2021

@khanhtc1202 Right. Let me update that part.

@nghialv
Copy link
Member Author

nghialv commented Jan 13, 2021

@khanhtc1202 Fixed it!

@khanhtc1202
Copy link
Member

Thank you 😁
/lgtm

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.09%. This pull request increases coverage by 0.09%.

File Function Base Head Diff
pkg/config/deployment_terraform.go TerraformDeploymentSpec.Validate 100.00% 66.67% -33.33%
pkg/config/config.go Config.init 80.00% 96.00% +16.00%
pkg/config/config.go Config.Validate 83.33% 66.67% -16.67%
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.Validate 0.00% 66.67% +66.67%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.Validate 0.00% 66.67% +66.67%

@pipecd-bot pipecd-bot merged commit 923e511 into master Jan 13, 2021
@pipecd-bot pipecd-bot deleted the config branch January 13, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default timeout value of deployment was not configured for CloudRun, Lambda, Terraform

5 participants