Skip to content

Conversation

@sanposhiho
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #356

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.77%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

nakabonne commented Jan 12, 2021

Yes, PersistentVolume.Status has its own Message, so we don't have to make a message for each status. Thank you!
/lgtm

@khanhtc1202
Copy link
Member

thank you
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 0c8f184 into master Jan 12, 2021
@pipecd-bot pipecd-bot deleted the health-state-persistent-volume branch January 12, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check health state of PersistentVolume resource

5 participants