Skip to content

Change disabled piped row styles on the piped list #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Jan 8, 2021
Merged

Change disabled piped row styles on the piped list #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions pkg/app/web/src/pages/settings/piped.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
MoreVert as MoreVertIcon,
FilterList as FilterIcon,
} from "@material-ui/icons";
import clsx from "clsx";
import dayjs from "dayjs";
import React, { FC, memo, useCallback, useState } from "react";
import { useDispatch, useSelector } from "react-redux";
Expand All @@ -47,24 +48,8 @@ import {
import { AppDispatch } from "../../store";

const useStyles = makeStyles((theme) => ({
item: {
backgroundColor: theme.palette.background.paper,
},
disabledPipedsAccordion: {
padding: 0,
},
disabledItemsSummary: {
borderBottom: "1px solid rgba(0, 0, 0, .125)",
},
pipedsList: {
flex: 1,
},
disabledItemsSecondaryHeader: {
color: theme.palette.text.secondary,
marginLeft: theme.spacing(3),
},
disabledItem: {
opacity: 0.6,
background: theme.palette.grey[200],
},
toolbarSpacer: {
flexGrow: 1,
Expand Down Expand Up @@ -197,7 +182,10 @@ export const SettingsPipedPage: FC = memo(function SettingsPipedPage() {
</TableHead>
<TableBody>
{pipeds.map((piped) => (
<TableRow key={`pipe-${piped.id}`}>
<TableRow
key={`pipe-${piped.id}`}
className={clsx({ [classes.disabledItem]: piped.disabled })}
>
<TableCell>
<Typography variant="subtitle2">
{`${piped.name} (${piped.id.slice(0, 8)})`}
Expand Down