Skip to content

Enable to give aws credentials file via value #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Dec 22, 2020
Merged

Enable to give aws credentials file via value #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/piped/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,7 @@ data:
{{- if .Values.secret.sealedSecretGCPKMS.decryptServiceAccount.data }}
{{ .Values.secret.sealedSecretGCPKMS.decryptServiceAccount.fileName }}: {{ .Values.secret.sealedSecretGCPKMS.decryptServiceAccount.data | b64enc | quote }}
{{- end }}
{{- if .Values.secret.awsCredentials.data }}
{{ .Values.secret.awsCredentials.fileName }}: {{ .Values.secret.awsCredentials.data | b64enc | quote }}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions manifests/piped/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ secret:
decryptServiceAccount:
fileName: sealed-secret-gcpkms-decrypt-service-account
data: ""
awsCredentials:
Copy link
Member

@nghialv nghialv Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this inside an imageProvider block?

Copy link
Member Author

@nakabonne nakabonne Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You intend to clearly distinguish from other use cases (e.g. Lambda Deployment), right? If so, agree with you!

Copy link
Member

@nghialv nghialv Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is the point.

Copy link
Member Author

@nakabonne nakabonne Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍

Copy link
Member

@khanhtc1202 khanhtc1202 Dec 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we have to configure credentials for each use-case for specific requirements? 🤔

Copy link
Member Author

@nakabonne nakabonne Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... on second thought I'm begging to feel we don't have to distinguish them as @khanhtc1202 may consider. In the general case, a piped operator prepares an AWS IAM user for piped and attach needed roles. I'd say it's an edge case to separate users by features.

Copy link
Member Author

@nakabonne nakabonne Dec 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FYI: the Go SDK for AWS is load credentials from the environment variables by default. It must be shared in a single process.)

Copy link
Member

@nghialv nghialv Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. 👍

fileName: aws-credentials
data: ""

nodeSelector: {}

Expand Down