Skip to content

Fix no namespace resource found on delete resource k8s #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 3 commits into from
Dec 18, 2020
Merged

Fix no namespace resource found on delete resource k8s #1281

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ed83a6
Fix no namespace resource found on delete resource k8s
khanhtc1202 Dec 17, 2020
7334ba5
Rename
khanhtc1202 Dec 18, 2020
789fe98
Fix comment
khanhtc1202 Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/app/piped/cloudprovider/kubernetes/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func (p *provider) ApplyManifest(ctx context.Context, manifest Manifest) error {
return p.initErr
}

return p.kubectl.Apply(ctx, p.input.Namespace, manifest)
return p.kubectl.Apply(ctx, p.getNamespaceToRun(manifest.Key), manifest)
}

// Delete deletes the given resource from Kubernetes cluster.
Expand All @@ -244,7 +244,16 @@ func (p *provider) Delete(ctx context.Context, k ResourceKey) (err error) {
return p.initErr
}

return p.kubectl.Delete(ctx, p.input.Namespace, k)
return p.kubectl.Delete(ctx, p.getNamespaceToRun(k), k)
}

// getNamespaceToRun returns namespace used on kubectl apply/delete commands.
// priority: config.KubernetesDeploymentInput > kubernetes.ResourceKey
func (p *provider) getNamespaceToRun(k ResourceKey) string {
if p.input.Namespace != "" {
return p.input.Namespace
}
return k.Namespace
}

func (p *provider) findKubectl(ctx context.Context, version string) (*Kubectl, error) {
Expand Down