Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

Add an option Edit to the piped list menu.

image

image

Which issue(s) this PR fixes:

Fixes #1220

Does this PR introduce a user-facing change?:

Add ability to edit piped configuration

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Dec 16, 2020

Nice.
/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 81.26%. This pull request decreases coverage by -0.15%.

File Base Head Diff
src/constants/toast-text.ts 100.00% 100.00% +0.00%
src/modules/pipeds.ts 72.41% 65.71% -6.70%

@khanhtc1202
Copy link
Member

Nice 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 485a3d4 into master Dec 16, 2020
@pipecd-bot pipecd-bot deleted the update-piped branch December 16, 2020 06:46
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to edit piped configuration

5 participants