Skip to content

Add responsible support to the DeploymentFrequencyChart #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Dec 11, 2020
Merged

Add responsible support to the DeploymentFrequencyChart #1240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 26 additions & 32 deletions pkg/app/web/src/components/deployment-frequency-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,22 @@ import {
XAxis,
CartesianGrid,
Tooltip,
ResponsiveContainer,
} from "recharts";
import dayjs from "dayjs";
import { theme } from "../theme";

const useStyles = makeStyles((theme) => ({
root: {
padding: theme.spacing(3),
width: 680,
},
chart: {
flex: 1,
minWidth: 600,
},
}));

interface Props {
data: InsightDataPoint.AsObject[];
}

const CHART_WIDTH = 600;
const CHART_HEIGHT = 400;

export const DeploymentFrequencyChart: FC<Props> = ({ data }) => {
const classes = useStyles();

Expand All @@ -44,38 +39,37 @@ export const DeploymentFrequencyChart: FC<Props> = ({ data }) => {
</Typography>
{data.length === 0 ? (
<Box
width={CHART_WIDTH}
height={CHART_HEIGHT}
display="flex"
alignItems="center"
justifyContent="center"
height={420}
>
<Typography variant="body1">No data</Typography>
</Box>
) : (
<LineChart
data={data}
width={CHART_WIDTH}
height={CHART_HEIGHT}
margin={{
top: 48,
right: 24,
left: 8,
bottom: 8,
}}
>
<CartesianGrid vertical={false} />
<Line
dataKey="value"
stroke={theme.palette.primary.main}
strokeWidth={2}
isAnimationActive={false}
dot={{ fill: theme.palette.primary.main }}
/>
<YAxis />
<XAxis dataKey="timestamp" tickFormatter={formatter} />
<Tooltip labelFormatter={formatter} />
</LineChart>
<ResponsiveContainer width="100%" aspect={2}>
<LineChart
data={data}
margin={{
top: 48,
right: 24,
left: 8,
bottom: 8,
}}
>
<CartesianGrid vertical={false} />
<Line
dataKey="value"
stroke={theme.palette.primary.main}
strokeWidth={2}
isAnimationActive={false}
dot={{ fill: theme.palette.primary.main }}
/>
<YAxis />
<XAxis dataKey="timestamp" tickFormatter={formatter} />
<Tooltip labelFormatter={formatter} />
</LineChart>
</ResponsiveContainer>
)}
</Paper>
);
Expand Down