Skip to content

Using utils getApplication instead of WebApi getApplication #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Dec 10, 2020
Merged

Using utils getApplication instead of WebApi getApplication #1230

pipecd-bot merged 1 commit into from
Dec 10, 2020

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 10, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

follow #1229

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Dec 10, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv changed the title Using utils getApplication insteads of WebApi getApplication Using utils getApplication instead of WebApi getApplication Dec 10, 2020
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

COVERAGE

Code coverage for golang is 33.90%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/app/api/grpcapi/utils.go getApplication 0.00% 57.14% +57.14%
pkg/app/api/grpcapi/web_api.go WebAPI.getApplication 57.14% -- -57.14%

@pipecd-bot pipecd-bot merged commit 2900100 into master Dec 10, 2020
@pipecd-bot pipecd-bot deleted the remove-web-api-get-application branch December 10, 2020 06:06
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nakabonne nakabonne Awaiting requested review from nakabonne

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved area/api release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khanhtc1202 @nghialv @pipecd-bot