Create insight data for change failure rate #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

pipecd-bot merged 30 commits into master from create-insight-data-for-change-failure-rate

Dec 9, 2020

pkg/app/api/grpcapi/web_api.go

-Original file line number
+Diff line change
@@ Expand Up @@
     		return nil, err
     	}
-    	switch req.MetricsKind {
-    	case model.InsightMetricsKind_DEPLOYMENT_FREQUENCY:
-    		return a.getInsightDataForDeployFrequency(ctx, claims.Role.ProjectId, req)
-    	}
-    	return nil, status.Error(codes.Unimplemented, "")
+    	return a.getInsightData(ctx, claims.Role.ProjectId, req)
     }
-    // getInsightDataForDeployFrequency returns the accumulated insight data for deploy frequency.
-    // This function is temporary implementation for front end.
-    func (a *WebAPI) getInsightDataForDeployFrequency(ctx context.Context, projectID string, req *webservice.GetInsightDataRequest) (*webservice.GetInsightDataResponse, error) {
+    func (a *WebAPI) getInsightData(ctx context.Context, projectID string, req *webservice.GetInsightDataRequest) (*webservice.GetInsightDataResponse, error) {
     	counts := make([]*model.InsightDataPoint, req.DataPointCount)
     	var movePoint func(time.Time, int) time.Time
@@ Expand All @@
     	}
     	for i := 0; i < int(req.DataPointCount); i++ {
-    		target := movePoint(start, i)
-    		filters := []datastore.ListFilter{
-    			{
-    				Field:    "ProjectId",
-    				Operator: "==",
-    				Value:    projectID,
-    			},
-    			{
-    				Field:    "CreatedAt",
-    				Operator: ">=",
-    				Value:    target.Unix(),
-    			},
-    			{
-    				Field:    "CreatedAt",
-    				Operator: "<",
-    				Value:    movePoint(target, 1).Unix(), // target's finish time on unix time
-    			},
-    		}
-    		if req.ApplicationId != "" {
-    			filters = append(filters, datastore.ListFilter{
-    				Field:    "ApplicationId",
-    				Operator: "==",
-    				Value:    req.ApplicationId,
-    			})
+    		targetRangeFrom := movePoint(start, i)
+    		targetRangeTo := movePoint(targetRangeFrom, 1)
+    		var getInsightDataForEachKind func(context.Context, string, string, time.Time, time.Time) (*model.InsightDataPoint, error)
+    		switch req.MetricsKind {
+    		case model.InsightMetricsKind_DEPLOYMENT_FREQUENCY:
+    			getInsightDataForEachKind = a.getInsightDataForDeployFrequency
+    		case model.InsightMetricsKind_CHANGE_FAILURE_RATE:
+    			getInsightDataForEachKind = a.getInsightDataForChangeFailureRate
+    		default:
+    			return nil, status.Error(codes.Unimplemented, "")
     		}
-    		pageSize := 50
-    		deployments, err := a.deploymentStore.ListDeployments(ctx, datastore.ListOptions{
-    			PageSize: pageSize,
-    			Filters:  filters,
-    		})
+    		count, err := getInsightDataForEachKind(ctx, projectID, req.ApplicationId, targetRangeFrom, targetRangeTo)
     		if err != nil {
-    			a.logger.Error("failed to get deployments", zap.Error(err))
-    			return nil, status.Error(codes.Internal, "Failed to get deployments")
-    		}
-    		counts[i] = &model.InsightDataPoint{
-    			Timestamp: target.Unix(),
-    			Value:     float32(len(deployments)),
+    			return nil, err
     		}
+    		counts[i] = count
     	}
     	return &webservice.GetInsightDataResponse{
     		UpdatedAt:  time.Now().Unix(),
     		DataPoints: counts,
     	}, nil
     }
+    // getInsightDataForDeployFrequency accumulate insight data in target range for deploy frequency.
+    // This function is temporary implementation for front end.
+    func (a *WebAPI) getInsightDataForDeployFrequency(
+    	ctx context.Context,
+    	projectID string,
+    	applicationID string,
+    	targetRangeFrom time.Time,
+    	targetRangeTo time.Time) (*model.InsightDataPoint, error) {
+    	filters := []datastore.ListFilter{
+    		{
+    			Field:    "ProjectId",
+    			Operator: "==",
+    			Value:    projectID,
+    		},
+    		{
+    			Field:    "CreatedAt",
+    			Operator: ">=",
+    			Value:    targetRangeFrom.Unix(),
+    		},
+    		{
+    			Field:    "CreatedAt",
+    			Operator: "<",
+    			Value:    targetRangeTo.Unix(), // target's finish time on unix time
+    		},
+    	}
+    	if applicationID != "" {
+    		filters = append(filters, datastore.ListFilter{
+    			Field:    "ApplicationId",
+    			Operator: "==",
+    			Value:    applicationID,
+    		})
+    	}
+    	pageSize := 50
+    	deployments, err := a.deploymentStore.ListDeployments(ctx, datastore.ListOptions{
+    		PageSize: pageSize,
+    		Filters:  filters,
+    	})
+    	if err != nil {
+    		a.logger.Error("failed to get deployments", zap.Error(err))
+    		return nil, status.Error(codes.Internal, "Failed to get deployments")
+    	}
+    	return &model.InsightDataPoint{
+    		Timestamp: targetRangeFrom.Unix(),
+    		Value:     float32(len(deployments)),
+    	}, nil
+    }
+    // getInsightDataForChangeFailureRate accumulate insight data in target range for change failure rate
+    // This function is temporary implementation for front end.
+    func (a *WebAPI) getInsightDataForChangeFailureRate(
+    	ctx context.Context,
+    	projectID string,
+    	applicationID string,
+    	targetRangeFrom time.Time,
+    	targetRangeTo time.Time) (*model.InsightDataPoint, error) {
+    	commonFilters := []datastore.ListFilter{
+    		{
+    			Field:    "ProjectId",
+    			Operator: "==",
+    			Value:    projectID,
+    		},
+    		{
+    			Field:    "CreatedAt",
+    			Operator: ">=",
+    			Value:    targetRangeFrom.Unix(),
+    		},
+    		{
+    			Field:    "CreatedAt",
+    			Operator: "<",
+    			Value:    targetRangeTo.Unix(), // target's finish time on unix time
+    		},
+    	}
+    	if applicationID != "" {
+    		commonFilters = append(commonFilters, datastore.ListFilter{
+    			Field:    "ApplicationId",
+    			Operator: "==",
+    			Value:    applicationID,
+    		})
+    	}
+    	filterForSuccessDeploy := []datastore.ListFilter{
+    		{
+    			Field:    "Status",
+    			Operator: "==",
+    			Value:    model.DeploymentStatus_DEPLOYMENT_SUCCESS,
+    		},
+    	}
+    	filterForFailureDeploy := []datastore.ListFilter{
+    		{
+    			Field:    "Status",
+    			Operator: "==",
+    			Value:    model.DeploymentStatus_DEPLOYMENT_FAILURE,
+    		},
+    	}
+    	pageSize := 50
+    	successDeployments, err := a.deploymentStore.ListDeployments(ctx, datastore.ListOptions{
+    		PageSize: pageSize,
+    		Filters:  append(filterForSuccessDeploy, commonFilters...),
+    	})
+    	if err != nil {
+    		a.logger.Error("failed to get deployments", zap.Error(err))
+    		return nil, status.Error(codes.Internal, "Failed to get deployments")
+    	}
+    	failureDeployments, err := a.deploymentStore.ListDeployments(ctx, datastore.ListOptions{
+    		PageSize: pageSize,
+    		Filters:  append(filterForFailureDeploy, commonFilters...),
+    	})
+    	if err != nil {
+    		a.logger.Error("failed to get deployments", zap.Error(err))
+    		return nil, status.Error(codes.Internal, "Failed to get deployments")
+    	}
+    	successCount := len(successDeployments)
+    	failureCount := len(failureDeployments)
+    	var changeFailureRate float32
+    	if successCount+failureCount != 0 {
+    		changeFailureRate = float32(failureCount) / float32(successCount+failureCount)
+    	} else {
+    		changeFailureRate = 0
+    	}
+    	return &model.InsightDataPoint{
+    		Timestamp: targetRangeFrom.Unix(),
+    		Value:     changeFailureRate,
+    	}, nil
+    }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create insight data for change failure rate #1197

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!