Create insight data for change failure rate #1197
Conversation
|
Failed while validating Kapetanios configuration. Details |
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
|
Code coverage for golang is
|
pkg/app/api/grpcapi/web_api.go
Outdated
| case model.InsightMetricsKind_DEPLOYMENT_FREQUENCY: | ||
| count, err := a.getInsightDataForDeployFrequency(ctx, projectID, req.ApplicationId, targetRangeFrom, targetRangeTo) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| counts[i] = count | ||
| case model.InsightMetricsKind_CHANGE_FAILURE_RATE: | ||
| count, err := a.getInsightDataForChangeFailureRate(ctx, projectID, req.ApplicationId, targetRangeFrom, targetRangeTo) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| counts[i] = count |
There was a problem hiding this comment.
nit: To avoid to be deeply nested, why not just do like:
var getInsightData func(context.Context, string, string, time.Time, time.Time)
switch req.MetricsKind {
case model.InsightMetricsKind_DEPLOYMENT_FREQUENCY:
getInsightData = getInsightDataForDeployFrequency
case model.InsightMetricsKind_CHANGE_FAILURE_RATE:
getInsightData = getInsightDataForChangeFailureRate
...
|
Code coverage for golang is
|
pkg/app/api/grpcapi/web_api.go
Outdated
| successCount := len(successDeployments) | ||
| failureCount := len(failureDeployments) | ||
|
|
||
| changeFailureRate := float32(failureCount) / float32(successCount+failureCount) |
There was a problem hiding this comment.
The number of deployments can be zero.
There was a problem hiding this comment.
I still didn't know enough about math...
(I thought 0/0 = 1)
|
Code coverage for golang is
|
pkg/app/api/grpcapi/web_api.go
Outdated
| if successCount+failureCount != 0 { | ||
| changeFailureRate = float32(failureCount) / float32(successCount+failureCount) | ||
| } else { | ||
| changeFailureRate = 1.0 |
|
Code coverage for golang is
|
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
ref #1142
Does this PR introduce a user-facing change?: