Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Dec 4, 2020

What this PR does / why we need it:

image
image

Which issue(s) this PR fixes:

Fixes #1146

Does this PR introduce a user-facing change?:

Add API key disabling on the web

@cakecatz cakecatz changed the title Implement API key disabling on the web WIP: Implement API key disabling on the web Dec 4, 2020
@cakecatz cakecatz changed the title WIP: Implement API key disabling on the web Implement API key disabling on the web Dec 4, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.27%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.22%. This pull request increases coverage by 0.04%.

File Base Head Diff
src/constants/toast-text.ts 100.00% 100.00% +0.00%
src/modules/api-keys.ts 84.85% 85.29% +0.45%

@khanhtc1202
Copy link
Member

/approve
thanks 🚀🚀🚀🚀🚀

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 5512ad5 into master Dec 4, 2020
@pipecd-bot pipecd-bot deleted the api-key-disabling branch December 4, 2020 08:32
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add managing web API key page

4 participants