Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Dec 3, 2020

What this PR does / why we need it:

  • exclude js files from @typescript-eslint/no-var-requires

Ref: #1181 (comment)

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

* exclude js files from no-var-requires
@khanhtc1202
Copy link
Member

/approve
thank you 🙏

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.28%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.14%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 26e7934 into master Dec 3, 2020
@pipecd-bot pipecd-bot deleted the update-eslint-rule branch December 3, 2020 05:04
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants