Skip to content

Conversation

@sanposhiho
Copy link
Member

What this PR does / why we need it:

According to QuickStart, the version of the helloworld image in kubernetes/canary/deployment.yaml L22 is v0.1.0, but in fact, v0.5.0 is correct.

fix it :)

Which issue(s) this PR fixes:

Fixes #1149

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Nov 27, 2020

Nice catch! Thank you.
/trigger presubmits
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv
Copy link
Member

nghialv commented Nov 27, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.96%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 5bcdba3 into pipe-cd:master Nov 27, 2020
@nakabonne
Copy link
Member

@sanposhiho Sorry for the lack of context, thank you!

@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The version of the helloworld image written in Quickstart does not match the actual manifest

4 participants