Skip to content

Change viewer and editor team of RBAC configuration to be optional #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Nov 20, 2020
Merged

Change viewer and editor team of RBAC configuration to be optional #1130

pipecd-bot merged 1 commit into from
Nov 20, 2020

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 20, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1129

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested review from cakecatz and gkuga November 20, 2020 02:22
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 20, 2020

COVERAGE

Code coverage for golang is 32.90%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/datastore/projectstore.go projectStore.UpdateProjectRBACConfig 0.00% 0.00% +0.00%
pkg/oauth/github/github.go OAuthClient.decideRole 94.44% 94.74% +0.29%
pkg/model/project.go ProjectRBACConfig.Update 100.00% -- -100.00%

@gkuga
Copy link
Contributor

gkuga commented Nov 20, 2020

/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 20, 2020

APPROVE

This pull request is APPROVED by gkuga.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 5f06a87 into master Nov 20, 2020
@pipecd-bot pipecd-bot deleted the rbac branch November 20, 2020 02:31
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakecatz cakecatz Awaiting requested review from cakecatz

@gkuga gkuga Awaiting requested review from gkuga

Assignees

No one assigned

Labels

approved release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change viewer and editor team of RBAC configuration to be optional

4 participants

@nghialv @pipecd-bot @gkuga