Add deployment chain model #2790
Conversation
|
Code coverage for golang is |
pkg/model/deployment_chain.proto
Outdated
|
|
||
| message DeploymentNode { | ||
| // List of applications which should be deployed at the same time in chain. | ||
| repeated Application applications = 1; |
There was a problem hiding this comment.
I think we have to think about this field.
Should it be a list of applications or a list of triggered deployments or a list of application IDs?
Could you share your thoughts about this?
There was a problem hiding this comment.
Btw, in the case of storing the application list, how can we have the status (info) of actually triggered deployments to show in the web console at the "Chains" tab?
There was a problem hiding this comment.
Ah, I get your point 👍 Since the name of this model is DeploymentChain it should be a chain of deployments, that what I was thought at first, but it looks like at the time we create this DeploymentChain model object, we don't trigger for deployment yet so that we don't have deployment object to use, my plan is to use ApplicationDeploymentReference. But I was wrong, we may need to add the ability to piped of the first application in the chain to enable it to trigger deployments for all applications in the chain and use it here 👍
There was a problem hiding this comment.
Thanks for your valuable comment 🙏 Addressed by 668b664
There was a problem hiding this comment.
we may need to add the ability to piped of the first application in the chain to enable it to trigger deployments for all applications in the chain and use it here
Actually, I still don't see a clear path for triggering all deployments from the first piped since some applications could be handled by other piped.
But it seems we have to store both application ref and deployment ref: all application ref are added when the deployment chain model is initialized, deployment refs are added when its piped triggers them.
I think it is hard to find out a perfect one at this time. So I am ok to merge this PR now and we can update the model if needed later.
pkg/model/deployment_chain.proto
Outdated
| string id = 1 [(validate.rules).string.min_len = 1]; | ||
| // The ID of the project this environment belongs to. | ||
| string project_id = 2 [(validate.rules).string.min_len = 1]; | ||
| // Deployment node contains all configuration required to perform deployment(s) |
|
Code coverage for golang is |
|
Code coverage for golang is |
|
/lgtm |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
**What this PR does / why we need it**: **Which issue(s) this PR fixes**: Follow PR #2790 **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: