Skip to content

Conversation

@nakabonne
Copy link
Member

@nakabonne nakabonne commented Nov 5, 2021

What this PR does / why we need it:
This PR adds labels fields to Applications/Deployments. And, since we plan to manage the labels of applications via its PipeCD deployment configuration (the .pipe.yaml file), we stop adding them when Add/UpdateApplication.
It just makes changes on the API side so no user-facing change will happen.

Which issue(s) this PR fixes:

Ref: #2750

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/model/application.go Application.ContainLabels -- 77.78% +77.78%
pkg/model/deployment.go Deployment.ContainLabels -- 77.78% +77.78%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateApplication 0.00% 0.00% +0.00%
pkg/model/application.go Application.ContainTags 88.89% -- -88.89%
pkg/model/deployment.go Deployment.ContainTags 88.89% -- -88.89%

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Create a command to send an application information defined in the application config

https://github.com/pipe-cd/pipe/blob/30721381d8477ea4bf931b374cffe8292f2c676d/pkg/app/api/grpcapi/web_api.go#L649-L652

This was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.

2. Enable to filter by labels

https://github.com/pipe-cd/pipe/blob/30721381d8477ea4bf931b374cffe8292f2c676d/pkg/app/api/service/apiservice/service.proto#L86-L89

This was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.

3. Add an rpc to update application info based on one defined in the application config

https://github.com/pipe-cd/pipe/blob/30721381d8477ea4bf931b374cffe8292f2c676d/pkg/app/api/service/pipedservice/service.proto#L165-L168

This was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.

4. Specify labels for ListApplications

https://github.com/pipe-cd/pipe/blob/30721381d8477ea4bf931b374cffe8292f2c676d/pkg/app/web/src/modules/applications/index.ts#L58-L61

This was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.

5. Specify labels for ListDeployments

https://github.com/pipe-cd/pipe/blob/30721381d8477ea4bf931b374cffe8292f2c676d/pkg/app/web/src/modules/deployments/index.ts#L105-L108

This was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/model/application.go Application.ContainLabels -- 77.78% +77.78%
pkg/model/deployment.go Deployment.ContainLabels -- 77.78% +77.78%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateApplication 0.00% 0.00% +0.00%
pkg/model/application.go Application.ContainTags 88.89% -- -88.89%
pkg/model/deployment.go Deployment.ContainTags 88.89% -- -88.89%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 8, 2021

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Nov 8, 2021
@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule manifests

Details
Error: unabled to get files: [quickstart]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants