-
Notifications
You must be signed in to change notification settings - Fork 205
Replace Tags with Labels to idendify applications/deployments #2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Collaborator
|
Code coverage for golang is
|
Collaborator
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Create a command to send an application information defined in the application configThis was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.2. Enable to filter by labelsThis was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.3. Add an rpc to update application info based on one defined in the application configThis was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.4. Specify labels for ListApplicationsThis was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne.5. Specify labels for ListDeploymentsThis was created by todo plugin since "TODO:" was found in 3072138 when #2751 was merged. cc: @nakabonne. |
Collaborator
|
Code coverage for golang is
|
Collaborator
Member
|
/lgtm |
Member
|
🚀 |
Collaborator
This was referenced Nov 8, 2021
Collaborator
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds labels fields to Applications/Deployments. And, since we plan to manage the labels of applications via its PipeCD deployment configuration (the
.pipe.yamlfile), we stop adding them when Add/UpdateApplication.It just makes changes on the API side so no user-facing change will happen.
Which issue(s) this PR fixes:
Ref: #2750
Does this PR introduce a user-facing change?: