Send notification to users via Slack when it fails to trigger deployment #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/piped/notifier/slack.go--- pkg/app/piped/notifier/slack.go.orig
+++ pkg/app/piped/notifier/slack.go
@@ -213,7 +213,7 @@
md := event.Metadata.(*model.NotificationEventPipedStopped)
title = "A piped has been stopped"
generatePipedEventData(md.Id, md.Name, md.Version, md.ProjectId)
-
+
case model.NotificationEventType_EVENT_PIPED_FAILED:
md := event.Metadata.(*model.NotificationEventPipedFailed)
title = "A piped failed to start"
|
pipecd-bot
reviewed
Nov 4, 2021
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
added 2 commits
November 4, 2021 21:57
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Nov 5, 2021
added 3 commits
November 5, 2021 11:25
… to "NotificationEventType_EVENT_DEPLOYMENT_TRIGGER_FAILED"
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/piped/trigger/deployment.go--- pkg/app/piped/trigger/deployment.go.orig
+++ pkg/app/piped/trigger/deployment.go
@@ -190,7 +190,7 @@
Metadata: &model.NotificationEventDeploymentTriggerFailed{
Application: app,
Commit: &model.GitCommit{
- Hash: commit.Hash,
+ Hash: commit.Hash,
Message: commit.Message,
},
Reason: reason,
|
Collaborator
|
Code coverage for golang is
|
Member
Author
|
I modified some fields as follows:
|
Member
Author
|
Updated 👍 |
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Nov 5, 2021
Member
Author
|
Updated 👍 |
nghialv
reviewed
Nov 10, 2021
Collaborator
|
Code coverage for golang is
|
Co-authored-by: Le Van Nghia <[email protected]>
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
Member
Author
|
Thanks! Updated 👍 |
nakabonne
reviewed
Nov 10, 2021
nakabonne
reviewed
Nov 10, 2021
Co-authored-by: Ryo Nakao <[email protected]>
Collaborator
|
Code coverage for golang is
|
Member
Author
|
Updated 👍 |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/piped/notifier/slack.go--- pkg/app/piped/notifier/slack.go.orig
+++ pkg/app/piped/notifier/slack.go
@@ -172,7 +172,7 @@
{"Commit", makeSlackLink(truncateText(msg, 8), commitURL), true},
}
}
-
+
}
generatePipedEventData := func(id, name, version, project string) {
link = fmt.Sprintf("%s/settings/piped?project=%s", webURL, project)
|
Member
Author
|
/golinter fmt |
Collaborator
|
Code coverage for golang is
|
nakabonne
reviewed
Nov 10, 2021
Co-authored-by: Ryo Nakao <[email protected]>
Collaborator
|
Code coverage for golang is
|
Member
|
There you go. Can't wait to show off this! |
Member
|
Good job! |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is related to #2742, but doesn't fix it. The following picture is an example.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: