Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Disable the GetInsightData requests on the insights page, the current insights page only for early access, shouldn't let its failed requests affect our monitoring board.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Enable fetch chart data on insight filter changes.

https://github.com/pipe-cd/pipe/blob/edff1174dd409a1d82dbe26a366a0d55f6959374/pkg/app/web/src/components/insight-page/insight-header/index.tsx#L104-L107

This was created by todo plugin since "TODO:" was found in edff117 when #2379 was merged. cc: @khanhtc1202.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.10%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.56%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 50c8b3f into master Aug 20, 2021
@pipecd-bot pipecd-bot deleted the disable-insight-api-call branch August 20, 2021 11:35
@khanhtc1202
Copy link
Member Author

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@khanhtc1202: Changelog has been generated in response to this comment.

Details

Changelog since v0.15.0

Notable Changes

  • Move application count badges to Insights page (#2377)
  • Enable insights tab on header (#2373)

Internal Changes

  • Disable call insights get data on insight page (#2379)
  • Add make web-test command (#2378)
  • Update manifests to allow specifying cloudrun credentials (#2375)
  • Divide Eventwatcher examples into multiple files (#2374)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants