Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
For durations, stats reported by Envoy is enough to see.

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.26%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 6, 2021
@nghialv
Copy link
Member

nghialv commented Jul 6, 2021

Could you add some metrics samples here? (e.g. envoy_cluster_grpc_*_upstream_rq_time_bucket)
That helps to review the use of regular expressions.

@nakabonne
Copy link
Member Author

@nghialv You're right.

Some examples here:

# TYPE envoy_cluster_grpc_service_webservice_WebService_GetInsightApplicationCount_upstream_rq_time histogram
envoy_cluster_grpc_service_webservice_WebService_GetInsightApplicationCount_upstream_rq_time_bucket{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api",le="0.5"} 0
envoy_cluster_grpc_service_webservice_WebService_GetInsightApplicationCount_upstream_rq_time_sum{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api"} 2770
envoy_cluster_grpc_service_webservice_WebService_GetInsightApplicationCount_upstream_rq_time_count{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api"} 6

# TYPE envoy_cluster_grpc_service_webservice_WebService_GetProject_upstream_rq_time histogram
envoy_cluster_grpc_service_webservice_WebService_GetProject_upstream_rq_time_bucket{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api",le="0.5"} 0
envoy_cluster_grpc_service_webservice_WebService_GetProject_upstream_rq_time_sum{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api"} 10.5
envoy_cluster_grpc_service_webservice_WebService_GetProject_upstream_rq_time_count{envoy_grpc_bridge_method="api",envoy_grpc_bridge_service="pipe",envoy_cluster_name="server-web-api"} 1

- source_labels: [__name__]
target_label: __name__
regex: envoy_cluster_grpc_(.+)_(.+)_(.+)_(.+)_upstream_rq_time_bucket$
replacement: pipecd_requests_duration_bucket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add envoy to the name? for example, pipecd_envoy_requests_

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, or pipecd_gateway_requests_ seems to be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this is a relabel_config for the pipecd-gateway job

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. That is better. 👍

@pipecd-bot pipecd-bot removed the lgtm label Jul 6, 2021
@nakabonne
Copy link
Member Author

Thank you for looking over. Applied them!

@nghialv
Copy link
Member

nghialv commented Jul 6, 2021

Nice.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 6, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.26%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 56ffd10 into master Jul 6, 2021
@pipecd-bot pipecd-bot deleted the add-relabel-to-duration branch July 6, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants