Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nakabonne
Copy link
Member

👍
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 2, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.60%. This pull request increases coverage by 0.02%.

File Function Base Head Diff
pkg/cache/cachemetrics/metrics.go IncGetOperationCounter 0.00% 100.00% +100.00%
pkg/cache/memorycache/cache.go Cache.Get 0.00% 0.00% +0.00%
pkg/cache/memorycache/lru_cache.go LRUCache.Get 75.00% 66.67% -8.33%
pkg/cache/memorycache/ttl_cache.go TTLCache.Get 100.00% 100.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jul 2, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b256706 into master Jul 2, 2021
@pipecd-bot pipecd-bot deleted the add-inmemory-cache-metrics branch July 2, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants