-
Notifications
You must be signed in to change notification settings - Fork 208
Update docs cover #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs cover #2141
Conversation
docs/content/en/_index.html
Outdated
|
|
||
| <div class="mx-auto"> | ||
| <a class="release-panel" target="_blank" href="https://github.com/pipe-cd/pipe/releases"> | ||
| PipeCD <span class="bolder">0.10.2</span> is now available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.10.2
It would be nice if this could be fetched automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would. Updating manually is quite tedious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, the current commit just because I don't actually know how to get that value. But as for an idea, maybe we could automatically generate it as we do with the release note? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cakecatz Is there any good way to add a script to load the latest version from this file when the page is loaded?
https://github.com/pipe-cd/pipe/blob/master/release/RELEASE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 this command (with jq) will fetch the latest tag name
curl --silent "https://api.github.com/repos/pipe-cd/pipe/releases/latest" | jq ".tag_name"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good except for doing a patch release. In that case, the tag and the version number specified in the RELEASE file will not be the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, then I need at least curl and cut command to process this data like below 👀
╰─ curl --silent https://raw.githubusercontent.com/pipe-cd/pipe/master/release/RELEASE | cut -c9-
v0.10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use "cut" for the local file. The whole repo was already cloned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed on 3f7e6e5 🙏
docs/content/en/_index.html
Outdated
| <a class="btn btn-lg btn-primary mr-3 mb-4" href="{{< relref "/docs" >}}"> | ||
| Learn More <i class="fas fa-arrow-alt-circle-right ml-2"></i> | ||
| <a class="btn btn-lg btn-primary mr-3 mb-4" href="{{< relref "/docs/quickstart/" >}}"> | ||
| Quick Start <span class="ml-2">🚀</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't really like this rocket icon much. Its color does not match our theme.
No strong opinion, but one vote from me to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay 😂 then what should I use there, should we keep the arrow as the existing version of the cover 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to use the previous arrow icon 🙏
|
Nice |
|
Nice. Thank you. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: