Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Update examples for Lambda application configuration.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.83%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jan 15, 2021

/lgtm

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.82%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/lambda/function.go FunctionManifestSpec.validate 66.67% 80.00% +13.33%

@pipecd-bot pipecd-bot merged commit c23e2cb into master Jan 15, 2021
@pipecd-bot pipecd-bot deleted the redesign-lambda-config branch January 15, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants