-
Notifications
You must be signed in to change notification settings - Fork 208
Fix the bug that default deployment timeout was not configured for all app kinds except Kubernetes #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…p kinds except Kubernetes
|
Code coverage for golang is
|
|
I think we should update the validation calling logic too 👀 |
|
@khanhtc1202 Right. Let me update that part. |
|
@khanhtc1202 Fixed it! |
|
Thank you 😁 |
nakabonne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
|
Code coverage for golang is
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1415
Does this PR introduce a user-facing change?: