Create API to get insight datas from insightstore #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/api/grpcapi/web_api_test.go--- pkg/app/api/grpcapi/web_api_test.go.orig
+++ pkg/app/api/grpcapi/web_api_test.go
@@ -21,13 +21,14 @@
"testing"
"github.com/golang/mock/gomock"
+ "github.com/stretchr/testify/assert"
+
"github.com/pipe-cd/pipe/pkg/app/api/service/webservice"
"github.com/pipe-cd/pipe/pkg/cache"
"github.com/pipe-cd/pipe/pkg/cache/cachetest"
"github.com/pipe-cd/pipe/pkg/datastore"
"github.com/pipe-cd/pipe/pkg/datastore/datastoretest"
"github.com/pipe-cd/pipe/pkg/model"
- "github.com/stretchr/testify/assert"
)
func Test_filterDeploymentConfigTemplates(t *testing.T) {
|
Member
Author
|
/golinter fmt |
… into fix-api-to-use-insightstore
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Dec 21, 2020
| PageSize: pageSize, | ||
| Filters: append(filterForSuccessDeploy, commonFilters...), | ||
| }) | ||
| chunks, err := a.insightstore.LoadChunks(ctx, claims.Role.ProjectId, req.ApplicationId, req.MetricsKind, req.Step, from, count) |
Member
There was a problem hiding this comment.
Can you add a TODO (before this line) about caching the insight data inside the cache service?
Member
|
/lgtm |
Collaborator
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. caching the insight data inside the cache serviceThis was created by todo plugin since "TODO:" was found in 21966ba when #1298 was merged. cc: @sanposhiho. |
Member
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
create api to get insight data from insight store
Which issue(s) this PR fixes:
Ref #1142
Does this PR introduce a user-facing change?: