Create insight collector #1287
Merged
Create insight collector #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
sanposhiho
force-pushed
the
create-insight-collector
branch
from
09f1ef1 to
0fc0b7d
Compare
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/ops/insightcollector/collector.go--- pkg/app/ops/insightcollector/collector.go.orig
+++ pkg/app/ops/insightcollector/collector.go
@@ -24,9 +24,10 @@
"github.com/pipe-cd/pipe/pkg/insightstore"
+ "go.uber.org/zap"
+
"github.com/pipe-cd/pipe/pkg/datastore"
"github.com/pipe-cd/pipe/pkg/model"
- "go.uber.org/zap"
)
var aggregateKinds = []model.InsightMetricsKind{
pkg/insightstore/datapoint_test.go--- pkg/insightstore/datapoint_test.go.orig
+++ pkg/insightstore/datapoint_test.go
@@ -18,8 +18,9 @@
"testing"
"time"
- "github.com/pipe-cd/pipe/pkg/model"
"github.com/stretchr/testify/assert"
+
+ "github.com/pipe-cd/pipe/pkg/model"
)
func Test_ExtractDataPoints(t *testing.T) {
|
pipecd-bot
reviewed
Dec 18, 2020
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
| return insightstore.ChangeFailureRate{}, time.Time{}, ErrDeploymentNotFound | ||
| } | ||
|
|
||
| var successCount int64 = 0 |
Collaborator
There was a problem hiding this comment.
should drop = 0 from declaration of var successCount; it is the zero value
| } | ||
|
|
||
| var successCount int64 = 0 | ||
| var failureCount int64 = 0 |
Collaborator
There was a problem hiding this comment.
should drop = 0 from declaration of var failureCount; it is the zero value
Member
Author
|
/golinter fmt |
Collaborator
|
Code coverage for golang is
|
…to create-insight-collector
Collaborator
|
Code coverage for golang is
|
pipecd-bot
reviewed
Dec 18, 2020
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
| } | ||
| } | ||
|
|
||
| maxUpdateAt = apps[len(apps)-1].UpdatedAt |
Collaborator
There was a problem hiding this comment.
ineffectual assignment to maxUpdateAt
pipecd-bot
reviewed
Dec 18, 2020
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
| return err | ||
| } | ||
| } | ||
| err = i.insightstore.PutChunk(ctx, chunk) |
Collaborator
There was a problem hiding this comment.
ineffectual assignment to err
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
Member
Author
|
@nghialv |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/api/grpcapi/web_api_test.go--- pkg/app/api/grpcapi/web_api_test.go.orig
+++ pkg/app/api/grpcapi/web_api_test.go
@@ -386,4 +386,4 @@
assert.Equal(t, tt.wantErr, err != nil)
})
}
-}
\ No newline at end of file
+}
|
Member
Author
|
/golinter fmt |
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Dec 22, 2020
cmd/pipecd/ops.go
Outdated
| cmd.Flags().IntVar(&s.adminPort, "admin-port", s.adminPort, "The port number used to run a HTTP server for admin tasks such as metrics, healthz.") | ||
| cmd.Flags().DurationVar(&s.gracePeriod, "grace-period", s.gracePeriod, "How long to wait for graceful shutdown.") | ||
|
|
||
| cmd.Flags().BoolVar(&s.enableInsightCollector, "enable-insight-collector", s.enableInsightCollector, "enable insight collector.") |
nghialv
reviewed
Dec 22, 2020
cmd/pipecd/ops.go
Outdated
| } | ||
| }() | ||
|
|
||
| // Set insight collector |
Member
There was a problem hiding this comment.
nit: "Starting a cron job for insight collector."
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Dec 22, 2020
cmd/pipecd/ops.go
Outdated
| httpPort int | ||
| adminPort int | ||
| gracePeriod time.Duration | ||
| enable bool |
nghialv
reviewed
Dec 22, 2020
| } | ||
| if err := collector.CollectApplicationInsight(ctx); err != nil { | ||
| t.Logger.Error("failed to run the application insight collector", zap.Error(err)) | ||
| } |
Member
There was a problem hiding this comment.
Btw, Could you add a log to show how long does each function take to run?
nghialv
reviewed
Dec 22, 2020
| err = i.updateApplicationChunks(ctx, p.Id, "", k, now) | ||
| if err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
I think we should continue working on other projects.
if err := i.updateApplicationChunks(ctx, p.Id, "", k, now); err != nil {
log the error
continue
}
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Dec 22, 2020
| break | ||
| } | ||
|
|
||
| for _, app := range apps { |
Member
There was a problem hiding this comment.
Let's ignore the deleted one.
if app.Deleted {
continue
}
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
Member
|
Thank you. |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create the data collector for insight.
Sorry this PR is getting so big.
It's because the test code is too big.
Which issue(s) this PR fixes:
Ref #1142
Does this PR introduce a user-facing change?: