Skip to content

Docs: the pipectl download command #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 2 commits into from
Dec 17, 2020
Merged

Docs: the pipectl download command #1272

pipecd-bot merged 2 commits into from
Dec 17, 2020

Conversation

@sano307
Copy link
Contributor

@sano307 sano307 commented Dec 17, 2020 •
edited
Loading

What this PR does / why we need it:

For beginners who are not familiar with the command, I added a download command for pipectl.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 17, 2020

CLA

Welcome @sano307!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@sano307
Copy link
Contributor Author

sano307 commented Dec 17, 2020

/cla sign

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 17, 2020

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

nghialv
nghialv reviewed Dec 17, 2020
View reviewed changes
@sano307 @nghialv
Update docs/content/en/docs/user-guide/command-line-tool.md
11b8619 
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
@nghialv
Copy link
Member

nghialv commented Dec 17, 2020

@sano307 Thanks for your pull request. You are absolutely right.
I have just left a comment.

@sano307
Copy link
Contributor Author

sano307 commented Dec 17, 2020

@nghialv
Thank you for the comment. I reflected your code suggestion.

@nghialv
Copy link
Member

nghialv commented Dec 17, 2020

@sano307 Great! Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 17, 2020

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@sano307 sano307 changed the title docs: the pipctl download command docs: the pipectl download command Dec 17, 2020
@nghialv
Copy link
Member

nghialv commented Dec 17, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 17, 2020

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@nghialv nghialv changed the title docs: the pipectl download command Docs: the pipectl download command Dec 17, 2020
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 17, 2020

COVERAGE

Code coverage for golang is 34.27%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 89e8d15 into pipe-cd:master Dec 17, 2020
@sano307 sano307 deleted the docs/download-pipctl branch December 17, 2020 08:22
@pipecd-bot pipecd-bot mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv nghialv left review comments

@nakabonne nakabonne Awaiting requested review from nakabonne

Assignees

No one assigned

Labels

approved area/docs area/site release-note-none size/XS trigger/needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sano307 @pipecd-bot @nghialv