Skip to content

Implement SyncApplication rpc for external api #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Dec 10, 2020
Merged

Implement SyncApplication rpc for external api #1229

pipecd-bot merged 1 commit into from
Dec 10, 2020

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Dec 10, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

KAPETANIOS

Failed while validating Kapetanios configuration.

Details 
Error: rpc error: code = NotFound desc = not found

@nghialv
Copy link
Member Author

nghialv commented Dec 10, 2020

/cc @nakabonne

@pipecd-bot pipecd-bot requested a review from nakabonne December 10, 2020 05:25
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

COVERAGE

Code coverage for golang is 33.87%. This pull request decreases coverage by -0.09%.

File Function Base Head Diff
pkg/app/api/grpcapi/api.go API.GetDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/api.go API.GetCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/utils.go getApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/utils.go addCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/api.go API.SyncApplication 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.SyncApplication 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.addCommand 0.00% -- +-0.00%

nakabonne
nakabonne approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks neat!

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit bf38633 into master Dec 10, 2020
@pipecd-bot pipecd-bot deleted the external-api branch December 10, 2020 05:40
@khanhtc1202 khanhtc1202 mentioned this pull request Dec 10, 2020
Merged
pipecd-bot pushed a commit that referenced this pull request Dec 10, 2020
@khanhtc1202
Using utils getApplication instead of WebApi getApplication (#1230)
2900100 
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

follow #1229 

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakecatz cakecatz Awaiting requested review from cakecatz

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

1 more reviewer

@nakabonne nakabonne nakabonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/api release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nghialv @pipecd-bot @nakabonne