Fix the bug that WAIT stage does not wait for the specified duration #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
changed the title
nghialv
reviewed
Dec 10, 2020
| return originalStatus | ||
| default: | ||
| return model.StageStatus_STAGE_FAILURE | ||
| } |
Member
There was a problem hiding this comment.
nit: Could you please change to use a return instead of the break at line 90.
for {
select {
case <- timer.C:
e.LogPersister.Infof("Waited for %v", totalDuration)
return model.StageStatus_STAGE_SUCCESS
case <-ticker.C:
e.LogPersister.Infof("%v elapsed...", time.Since(startTime))
case s := <-sig.Ch():
....
}
}
}
Contributor
Author
There was a problem hiding this comment.
thanks, I fixed it in git commit --amend
ShotaKitazawa
force-pushed
the
piped-wait
branch
from
821a992 to
62a7121
Compare
Member
|
/trigger presubmits |
Collaborator
|
@nghialv: Your requested presubmits has been scheduled in response to this comment. |
Member
|
@ShotaKitazawa Thank you very much. |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
Code coverage for golang is |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix
WAITstage in KubernetesAppWhich issue(s) this PR fixes:
Fixes #1225
Does this PR introduce a user-facing change?: