Skip to content

Conversation

@ShotaKitazawa
Copy link
Contributor

What this PR does / why we need it:

fix document:
In architecture overview of control-plane, written as cache used by api. I think cache use by server is correct after PipeCD v0.8.0.

If I am wrong, please close this PR.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

CLA

Welcome @ShotaKitazawa!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@ShotaKitazawa
Copy link
Contributor Author

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@nghialv nghialv changed the title fix document in control-plane/architecture-overview: "api" > "server" Fix document in control-plane/architecture-overview: "api" > "server" Dec 10, 2020
@nghialv
Copy link
Member

nghialv commented Dec 10, 2020

@ShotaKitazawa Thank you for your pull request.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv
Copy link
Member

nghialv commented Dec 10, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.96%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 856feaf into pipe-cd:master Dec 10, 2020
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants