Read password and username via file from MongoDB datasource #1168
Conversation
nakabonne
left a comment
nakabonne
left a comment
There was a problem hiding this comment.
Great work. Left a trivial comment, while looks pretty neat entirely. Thank you!
pkg/datastore/mongodb/mongodb.go
Outdated
| const ( | ||
| // Scram type ref https://github.com/mongodb/mongo-go-driver/blob/9e2aca8afd8821e6b068cc2f25192bc640d90a0d/mongo/client_examples_test.go#L119 | ||
| // Default | ||
| Scram string = "SCRAM" |
There was a problem hiding this comment.
nit: I feel like we can keep it private until needed.
There was a problem hiding this comment.
@nakabonne Thanks for your review, I change it to unexported one. Please check again when you have time 👍 👍
|
/trigger presubmit |
|
/trigger presubmits |
|
@nakabonne: Your requested presubmits has been scheduled in response to this comment. |
|
Code coverage for golang is |
| } | ||
| return mongodb.NewMongoDB(ctx, mdConfig.URL, | ||
| mdConfig.Database, | ||
| options...) |
There was a problem hiding this comment.
nit: Just want to be unified with our coding conventions.
mongodb.NewMongoDB(
ctx,
mdConfig.URL,
...,
)
There was a problem hiding this comment.
@nghialv
Thanks for your review.
I changed it to match the coding conventions. Please check it again when you have time 👍 👍
|
/lgtm |
|
/trigger presubmits |
|
@nakabonne: Your requested presubmits has been scheduled in response to this comment. |
|
@tnqv Thank you. You're the best! |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
4 participants
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #683
Does this PR introduce a user-facing change?: