-
Notifications
You must be signed in to change notification settings - Fork 205
Add namespace to template helm chart #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @tnqv . A nice and well-tested pull request. Love it. Thank you. |
|
/trigger presubmits |
|
@nghialv: Your requested presubmits has been scheduled in response to this comment. |
|
Code coverage for golang is
|
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use |
|
@nghialv Thanks for your review!! 👍 |
|
/todo skip |
|
/trigger presubmits |
|
@nghialv: Your requested presubmits has been scheduled in response to this comment. |
|
Nice. Thank you very much. |
|
Code coverage for golang is
|
What this PR does / why we need it:
TemplateLocalChartandTemplateRemoteCharthave not setnamespaceyet.Which issue(s) this PR fixes:
Fixes #789
Does this PR introduce a user-facing change?: