Skip to content

Conversation

@tnqv
Copy link
Contributor

@tnqv tnqv commented Nov 20, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #789

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Nov 20, 2020

Hi @tnqv .

A nice and well-tested pull request. Love it. Thank you.
I have just left a suggestion. 💯

@nghialv
Copy link
Member

nghialv commented Nov 20, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.95%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/manifest.go Manifest.GetNestedMap -- 75.00% +75.00%
pkg/app/piped/cloudprovider/kubernetes/helm.go Helm.TemplateLocalChart 66.67% 70.00% +3.33%
pkg/app/piped/cloudprovider/kubernetes/helm.go Helm.TemplateRemoteChart 0.00% 0.00% +0.00%
pkg/app/piped/toolregistry/registry.go registry.Helm 82.35% 88.24% +5.88%

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Preinstall a helm version inside CI runner to avoid installing.

https://github.com/pipe-cd/pipe/blob/f4bc3691c2ae680f6a458b86cba84110a944a3fe/pkg/app/piped/cloudprovider/kubernetes/helm_test.go#L59-L62

This was created by todo plugin since "TODO:" was found in f4bc369 when #1132 was merged. cc: @tnqv.

@tnqv
Copy link
Contributor Author

tnqv commented Nov 20, 2020

@nghialv Thanks for your review!! 👍
I refactored, please check again when you have time!

@nghialv
Copy link
Member

nghialv commented Nov 20, 2020

/todo skip

@nghialv
Copy link
Member

nghialv commented Nov 20, 2020

/trigger presubmits

@tnqv tnqv requested a review from nghialv November 20, 2020 07:24
@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@nghialv
Copy link
Member

nghialv commented Nov 20, 2020

Nice. Thank you very much.

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.95%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/manifest.go Manifest.GetNestedMap -- 75.00% +75.00%
pkg/app/piped/cloudprovider/kubernetes/helm.go Helm.TemplateLocalChart 66.67% 70.00% +3.33%
pkg/app/piped/cloudprovider/kubernetes/helm.go Helm.TemplateRemoteChart 0.00% 0.00% +0.00%
pkg/app/piped/toolregistry/registry.go registry.Helm 82.35% 88.24% +5.88%

@pipecd-bot pipecd-bot merged commit 309a5d3 into pipe-cd:master Nov 20, 2020
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unavailable helm install with "--namespace' option

3 participants