High memory consumption

[zdila]

Description

Cmpiling application with couple of reducers (~20) and action creators (~200) takes 2 GB RAM and requires passing --max-old-space-size to node when invoking tsc. Before fixing #164 it was much worse but it is still unuseable.

Steps to Reproduce

Steps to reproduce the behavior:

1. Download and unpack https://drive.google.com/file/d/1FUzk5NeRfxUvwd4eXCxIFcb7Scmvh9D4/view?usp=sharing
2. run npm i
3. run node --max-old-space-size=8192 ./node_modules/.bin/tsc --diagnostics
4. See the result

Expected behavior

Compilation of such project should be a piece of cake ;-)

Suggested solution(s)

Improve types or identify bug in TypeScript.

Project Dependencies

• Typesafe-Actions Version: 4.4.1
• TypeScript Version: 3.5.2
• tsconfig.json: included in the tgz

Environment (optional)

• OS: Debian Linux Buster
• Node Version: 12.4.0
• Package Manager and Version: npm 6.9.0

---

IssueHunt Summary

[
<
i
m
g

s
r
c

'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
0
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
7
3
9
0
7
5
?
v

4
'

a
l
t

'
p
i
o
t
r
w
i
t
e
k
'

w
i
d
t
h

2
4

h
e
i
g
h
t

2
4

p
i
o
t
r
w
i
t
e
k
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
p
i
o
t
r
w
i
t
e
k
)

h
a
s

b
e
e
n

r
e
w
a
r
d
e
d
.

Backers (Total: $140.00)

• issuehunt ($140.00)

Submitted pull Requests

• #171 #168

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[hsz]

I can confirm that as well. Cold start of tsc still takes too much of the resources and time.

[mmalicki]

Probably related to this, I noticed when I changed all my reducers from standard switch case to createReducer, compiler typechecking and autocomplete (in both VSCode and IntelliJ) slowed down noticably to the point where it's painful to use

[zdila]

@mmalicki that was actually also my case

[piotrwitek]

Thanks for the reproduction case 👍. I have confirmed an issue and will be working on that.

[issuehunt-oss]

@issuehunt has funded $140.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[hilkeheremans]

I can also confirm the issue. Thanks so much for looking into it!

[piotrwitek]

PR is ready, now it's infinitely scalable. will release a new version tomorrow.

@zdila You can test it now using the following in your project to confirm:
npm i piotrwitek/typesafe-actions##168

[zdila]

@piotrwitek thanks, but with npm i piotrwitek/typesafe-actions##168 there is no more dist in node_modules/typesafe-actions.

[piotrwitek]

@zdila you can build the project locally and copy the dist folder or wait for me to release under the next branch in a few hours

[piotrwitek]

Published on npm as @next

[issuehunt-oss]

@piotrwitek has rewarded $98.00 to @piotrwitek. See it on IssueHunt

• 💰 Total deposit: $140.00
• 🎉 Repository reward(20%): $28.00
• 🔧 Service fee(10%): $14.00

[hsz]

Shouldn't that be released as v4.5.0 since it's a major performance issue?

[piotrwitek]

There is a breaking change in the API and I'm respecting semver.
But I might consider it if that is something critical to the majority of the users.

[hsz]

After upgrading to @next release, project hangs on tsc again with memory leak at the end (19x createAsyncAction, 1x createStandardAction).
4.4.2 is working fine.
What can I do to provide you more details?

[zdila]

In my case typesafe-actions@next works now fine on my project. Thanks Piotr.

[piotrwitek]

@hsz take a look at a great reproduction example from @zdila above and try to isolate the issue in your project in the same way. Only this way we can confirm the issue is on our end and not within your application setup.