-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indent bug for tables without headers (issue piotrmurach/tty-table/issues/45) #44
base: master
Are you sure you want to change the base?
Fix indent bug for tables without headers (issue piotrmurach/tty-table/issues/45) #44
Conversation
it "indents top border correctly" do | ||
table = TTY::Table.new | ||
table << ["a1","a2","a3"] | ||
table << ["b1","b2","b3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/WordArray: Use %w or %W for an array of words.
Layout/SpaceAfterComma: Space missing after comma.
RSpec.describe TTY::Table::Renderer::ASCII, 'indentation without headers' do | ||
it "indents top border correctly" do | ||
table = TTY::Table.new | ||
table << ["a1","a2","a3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/WordArray: Use %w or %W for an array of words.
Layout/SpaceAfterComma: Space missing after comma.
@@ -37,3 +37,17 @@ | |||
end | |||
end | |||
end | |||
|
|||
RSpec.describe TTY::Table::Renderer::ASCII, 'indentation without headers' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This has failed at appveyor because of a github connectivity issue rather than a test failure. I don't know how to re-run the job so I will push a trivial change. |
Describe the change
There is a bug rendering tables without headers with an indent. The top border is not indented.
Why are we doing this?
Bug fix.
Benefits
Bug fix.
Drawbacks
None.
Here is come code that demonstrates the problem:
Requirements
master
branch?